Closed
Conversation
ppolewicz
commented
Nov 3, 2025
| || (price == candidate_price && registered_at < candidate_timestamp) | ||
| let priority = SubnetDeregistrationPriority::<T>::get(netuid); | ||
|
|
||
| // Prioritize higher deregistration priority, then lowest price, then earliest registration. |
Author
There was a problem hiding this comment.
it's a bit weird but it's O(N) and the tests pass
| ); | ||
|
|
||
| let current_block: BlockNumberFor<T> = <frame_system::Pallet<T>>::block_number(); | ||
| let delay: BlockNumberFor<T> = ColdkeySwapScheduleDuration::<T>::get(); |
Author
There was a problem hiding this comment.
I feel we should have a separate setting for this, but the hyperparameter framework will overhaul this imminently anyway
| SubnetDeregistrationPrioritySchedule::<T>::take(netuid).is_some(); | ||
|
|
||
| if was_flagged || had_schedule { | ||
| Self::deposit_event(Event::SubnetDeregistrationPriorityCleared(netuid)); |
Author
There was a problem hiding this comment.
should have separate events for those two cases?
| #[pallet_section] | ||
| mod events { | ||
| use codec::Compact; | ||
| use frame_system::pallet_prelude::BlockNumberFor; |
Author
There was a problem hiding this comment.
I don't understand why BlockNumberFor used to work without this? It's used in other places in the same file, dissolution, chk
- change RootClaimed key order
…-fees Disable root claim fees.
…lution-optimization2
Init flows instead of transition, set temperature = 1.0
…n-optimization2 Network dissolution optimization for root claim
Feat/new coinbase
Fix e2e CI + evm test
Distribute leasing dividends as alpha instead of tao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think there is a BIT for it yet?