fix(pi): strip planning-only tools on fresh idle sessions#525
Merged
backnotprop merged 1 commit intobacknotprop:mainfrom Apr 8, 2026
Merged
fix(pi): strip planning-only tools on fresh idle sessions#525backnotprop merged 1 commit intobacknotprop:mainfrom
backnotprop merged 1 commit intobacknotprop:mainfrom
Conversation
PR backnotprop#446 refactored the session_start handler to use applyPhaseConfig() but changed the idle branch to only call restoreSavedState(), which no-ops when savedState is null (i.e., fresh sessions that were never in planning mode). This left plannotator_submit_plan in the active tool set even though plan mode hadn't been activated — a regression from the fix in backnotprop#387. Now the idle branch explicitly strips planning-only tools when there is no saved state to restore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #446 refactored the
session_starthandler to useapplyPhaseConfig()but changed the idle branch to only callrestoreSavedState(), which no-ops whensavedStateisnull(i.e., fresh sessions that were never in planning mode). This leftplannotator_submit_planin the active tool set even though plan mode hadn't been activated — a regression from the fix in #387.Root Cause
In the
session_starthandler, the idle branch was:When
savedStateisnull(fresh session, never entered planning),restoreSavedState()returns immediately at line 204 without callingsetActiveTools(), soplannotator_submit_planis never stripped.Fix
The idle branch now explicitly strips planning-only tools when there is no saved state to restore:
This restores the guarantee from #387 that
plannotator_submit_planis always removed from the active tool set when not in planning mode.