Skip to content

rack dependency update#1

Open
norepIy wants to merge 3 commits intocore-0-8-stablefrom
dependency_update_off_core_0_8_stable
Open

rack dependency update#1
norepIy wants to merge 3 commits intocore-0-8-stablefrom
dependency_update_off_core_0_8_stable

Conversation

@norepIy
Copy link
Copy Markdown

@norepIy norepIy commented Nov 16, 2017 •
edited
Loading

  • bumps rack requirement to 2.0, jwt to 1.5.6.
  • all tests passing.
  • PR is against the base branch that we're currently using

@norepIy norepIy changed the base branch from master to core-0-8-stable November 16, 2017 21:32
jfrancese-datto
jfrancese-datto approved these changes Nov 16, 2017
View reviewed changes
Copy link
Copy Markdown

@jfrancese-datto jfrancese-datto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dattocgernon
dattocgernon approved these changes Nov 16, 2017
View reviewed changes
Copy link
Copy Markdown

@dattocgernon dattocgernon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dattocgernon dattocgernon dattocgernon approved these changes

@jfrancese-datto jfrancese-datto jfrancese-datto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@norepIy @dattocgernon @jfrancese-datto