Change GMC module to extend PottsModule instead of PottsProliferationModule#197
Closed
Change GMC module to extend PottsModule instead of PottsProliferationModule#197
Conversation
cainja
approved these changes
Oct 17, 2025
Member
Author
|
@cainja I actually think I'm going to change the way I have done this. Because both the GMCs and the Stem cells will need to have "proliferation" modules that do not step through the cell cycle, I think I want to make a different proliferation abstract class that mimics the patch proliferation module in that it does not have explicit progression through each phase of the cell cycle. Then both the GMCs and Stem cells can implement that abstract class. |
Member
Author
|
Closing because #199 addresses this issue in a different more scalable way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estimated time to review: small
Brief justification of changes
We do not have good experimental data to inform the parameters defining time spent in each phase of the cell cycle for the fly cell agents. We therefore want to remove the phases of the cell cycle from the "proliferation" (in this case differentiation) modules of the fly cells. This pull request removes progression through the cell cycle from the GMC differentiation module.
Summary of changes