Skip to content

Fix: conflict between Raw64 and PlaintextNames flags in config #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
monkberry71 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: conflict between Raw64 and PlaintextNames flags in config #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions libcppcryptfs/config/cryptconfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,8 +872,11 @@ bool CryptConfig::create(const WCHAR *path, const WCHAR *specified_config_file_p
if (siv)
m_AESSIV = true;

// Raw64 and HKDF default to true
m_Raw64 = true;
// Raw64 defaults to true, but must be disabled if PlaintextNames is active
// (PlaintextNames implies filenames are not encrypted, so Base64 encoding is conflicting)
m_Raw64 = !m_PlaintextNames;

// HKDF default to true
m_HKDF = true;

if (reverse)
Expand Down