Merge feature/shamir-secret-sharing-o2a into main#16
Conversation
Add a security policy document outlining supported versions and vulnerability reporting.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def parse_transaction(tx_hex): | ||
| """Parse Bitcoin transaction and extract all signatures""" | ||
| data = bytes.fromhex(tx_hex) | ||
| offset = 0 | ||
|
|
||
| # Version | ||
| version = int.from_bytes(data[offset:offset+4], 'little') | ||
| offset += 4 | ||
|
|
||
| # Number of inputs | ||
| num_inputs, offset = parse_varint(data, offset) |
There was a problem hiding this comment.
The transaction parser assumes the byte immediately after the version is the varint-encoded input count. In SegWit transactions the version is followed by the 0x00/0x01 marker and flag before the input count, so this code interprets the marker as the input count and the whole structure becomes misaligned. For any modern SegWit transaction, parse_transaction will either return zero signatures or raise when offsets run past the buffer, so the nonce analysis silently fails. Detect the SegWit marker/flag and skip them before calling parse_varint.
Useful? React with 👍 / 👎.
…shamir-secret-sharing-o2a
…shamir-secret-sharing-o2a
commit 860fc30 Author: bakaxbaka <profesyonelceset@gmail.com> Date: Tue Nov 4 15:40:00 2025 +0300 Add Contributor Covenant Code of Conduct This document outlines the standards of behavior expected from community members and the enforcement procedures for violations.
commit b60f59e Author: bakaxbaka <bakaxbaka@users.noreply.github.com> Date: Thu Nov 20 20:27:07 2025 +0300 Squashed commit of the following: commit 9fed685 Author: bakaxbaka <profesyonelceset@gmail.com> Date: Tue Nov 4 15:36:55 2025 +0300 Create SECURITY.md for security policy Add a security policy document outlining supported versions and vulnerability reporting. commit 2a8c25e Merge: 521ee19 9827d2e Author: bakaxbaka <bakaxbaka@users.noreply.github.com> Date: Thu Nov 20 20:26:28 2025 +0300 Merge branch 'codex/replace-sighash-logic-in-main.py' into feature/manus-ai-agent-integration-n1a commit 9827d2e Merge: aae28db d3ccab5 Author: bakaxbaka <bakaxbaka@users.noreply.github.com> Date: Thu Nov 20 20:24:34 2025 +0300 Merge branch 'main' into codex/replace-sighash-logic-in-main.py commit 521ee19 Author: BLACKBOX Agent <agent@example.com> Date: Tue Nov 4 21:31:37 2025 +0000 fix the code # Claude Integration Guide **FOR CL... commit 1572f3b Author: BLACKBOX Agent <agent@example.com> Date: Tue Nov 4 21:19:44 2025 +0000 chore: add core dependencies for async web framework commit aae28db Author: bakaxbaka <profesyonelceset@gmail.com> Date: Tue Oct 28 07:59:47 2025 +0300 Implement accurate Bitcoin sighash calculation
commit 76c2517 Author: BLACKBOX Agent <agent@example.com> Date: Tue Nov 4 01:35:33 2025 +0000 020000005800bb13b1ecc77e537bd8d0bf70055bf29f133c7c...
1 participant
Automated PR created from task completion