Traction Modem Reset Link Timeout on Any Rx #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balazsracz
reviewed
Sep 14, 2025
| } | ||
|
|
||
| /// Register for a callback when any packet is received. | ||
| virtual void register_packet_rx_callback(std::function<void()> callback) |
Collaborator
There was a problem hiding this comment.
this probably should not be virtual, since the only meaningful implementation is inline here.
balazsracz
approved these changes
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue when doing firmware updates on the main decoder MCU. Basically, execution stalls whenever FLASH is erased/programmed. This causes the main decoder MCU to miss an occasional ping, and since we only reset the link timeout on a pong response, this results in a link down, eventually.
This could also be an issue for other memory space writes, such as CVs.