Redis error#23
Open
danjenkins wants to merge 3 commits intobalderdashy:0.9.xfrom
Open
Conversation
So that end users can handle the connection how they want when bad things happen
|
This is fantastic, that was one of my concerns is that if the Redis server went down temporarily it would take our server down with it. I hope we can merge this into the 0.9 code base ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unable to attach an onError handler to the raw redis connection, so when we lost connectivity to redis, the node app would just kick up a fuss, I wanted to be able to deal with that how I wanted. While I was at it, I added the possibility of listening for onReady so that you can also have your own logic for when the connection is ready.
I also made it so that when on error gets called, we pass back the raw connection so that you can say, listen for ready again and know that you've reconnected.