Open
Conversation
|
Amazing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to test multiple speed/acceleration combinations in a single PA Pattern calibration print, like OrcaSlicer. Original work here: https://github.com/OrcaSlicer/OrcaSlicer/pull/7199/changes#diff-eca08a5705cbb985a1c40eec4d872104395681026980e05ce808dbd5445c4691
Instead of running one calibration at a time, you can enter comma-separated speeds (e.g. 60,200) and accelerations (e.g. 2000,5000) in the calibration dialog. Each combination gets its own labeled pattern, automatically arranged across plates when they don't all fit on one.
Added validation for min and max speed and accelerations.
Right side prints the speed/acceleration as well, to easily distinguish between tests.
Tested on my H2C.