Skip to content

Add 12-hour time format (AM/PM) setting#9789

Open
BobbyLindsey wants to merge 1 commit intobambulab:masterfrom
BobbyLindsey:AM-PM
Open

Add 12-hour time format (AM/PM) setting#9789
BobbyLindsey wants to merge 1 commit intobambulab:masterfrom
BobbyLindsey:AM-PM

Conversation

@BobbyLindsey
Copy link

@BobbyLindsey BobbyLindsey commented Feb 18, 2026

Implement user preference for 12-hour time format with AM/PM indicator:

  • Add use_12hour_time config setting (default: false for 24-hour format)
  • Update get_bbl_finish_time_dhm() to support 12-hour formatting
  • Add checkbox in Preferences > General Settings
  • Read setting and pass to formatter in StatusPanel

When enabled, finish time displays as "2:30 PM" instead of "14:30".

With setting enabled:
Screenshot 2026-02-19 at 9 32 41 AM

Added setting:
Screenshot 2026-02-19 at 9 33 28 AM

Implement user preference for 12-hour time format with AM/PM indicator:
- Add use_12hour_time config setting (default: false for 24-hour format)
- Update get_bbl_finish_time_dhm() to support 12-hour formatting
- Add checkbox in Preferences > General Settings
- Read setting and pass to formatter in StatusPanel

When enabled, finish time displays as "2:30 PM" instead of "14:30".

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@BobbyLindsey BobbyLindsey marked this pull request as ready for review February 18, 2026 04:31
@BobbyLindsey
Copy link
Author

@JohnSmithCYM Can you get this reviewed?

@BobbyLindsey
Copy link
Author

@lanewei120 Can you review and merge this so that it goes into the next release? It's a very simple change.

@lanewei120
Copy link
Collaborator

Sorry for the late reply due to the Spring Festival holidays.

Previously there is a similiar patch #9187
we merged it and found some crash before the last release

so we reverted that patch
and will add it back soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants