Fix SwitchBoard control not registering left side mouse clicks when shown on secondary left side monitors.#9854
Open
mpaperno wants to merge 1 commit intobambulab:masterfrom
Open
Conversation
… shown on secondary monitors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When a
SwitchBoardcontrol was shown on a secondary monitor, to the left of the primary, the control would never register a click on the left half. Therefore it was not possible to select the left option/toggle in several places, for example to switch back from "Hotends" view to "Filaments" in the device status panel.Cause:
This was due to
ClientToScreen(wxMouseEvent::GetPosition())returning negative X values on screens arranged to the left of primary, which is how screen coordinates are typically reported.Fix:
It is not necessary to do any coordinate mapping at all in this case because the mouse click's
wxMouseEvent.GetPosition()is already in local widget coordinates (0,0 is always widget top left). So it is enough to simply check where the click X was in relation to half the control's current width.UI Elements Affected (indirectly):
StatusPanelStatusPanelPrintOptionsDialogandSafetyOptionsDialogPrintOptionsDialogAmsReplaceMaterialDialog("Auto Refill")Thanks for your consideration,
-Max