Calculate scaled factors for pixel with react-native-pixel-perfect#126
Calculate scaled factors for pixel with react-native-pixel-perfect#126giolaq wants to merge 1 commit intobamlab:mainfrom
Conversation
|
It makes sense but I'm not sure there is that much added value: the calculation is very simple and is present only once in the codebase, in a separate place 😁 Maybe there are additional features that I missed? |
|
Agree that adding a dependency for this is an overkill. I found that testing on Fire TV/Android TV emulator/Web was giving me some issue with the UI not following the same proportions. I have tested with the react-native-pixel-perfect and all was fixed. I think their formula maybe is more completed as taking as variable also the height. |
I've found the using react-native-pixel-perfect makes it easier to adapt the scaling factor across different screens.
The library is considering width and height that can be defined by the developers or runtime.
Tested on Android TV, Fire TV, tvOS and web.
Check if it makes sense! Thank you!