Skip to content

chore: update api spec#751

Open
everpcpc wants to merge 2 commits intobangumi:masterfrom
everpcpc:fix-api
Open

chore: update api spec#751
everpcpc wants to merge 2 commits intobangumi:masterfrom
everpcpc:fix-api

Conversation

@everpcpc
Copy link
Contributor

@everpcpc everpcpc commented Feb 21, 2025

@everpcpc everpcpc requested a review from trim21 February 21, 2025 03:00
@mergify mergify bot added the waiting-approval waiting code reviewers to approval PR label Feb 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Preview Deployment

Build URL time
Sites netlify preview 2025-01-05 04:33:33Z
Storybook netlify preview 2025-01-05 04:32:59Z

@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 21, 2025
@everpcpc everpcpc requested a review from a team February 21, 2025 04:35
return (
<div className={styles.groupTopicHeader}>
<Avatar src={creator.avatar.large} size='medium' />
<Avatar src={creator?.avatar.large ?? ''} size='medium' />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 avatar 可能为空吗?似乎为空就啥也不展示了

<div>
<Link to={getUserProfileLink(creator.username)} isExternal>
{creator.nickname}
<Link to={getUserProfileLink(creator?.username ?? '')} isExternal>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有这里 username 有为空的情况吗

@cokemine
Copy link
Member

还有username 和nickname为啥也能为空

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M waiting-approval waiting code reviewers to approval PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants