Skip to content

Add vite 8 support#242

Merged
montalvomiguelo merged 5 commits intomainfrom
vite-8
Mar 14, 2026
Merged

Add vite 8 support#242
montalvomiguelo merged 5 commits intomainfrom
vite-8

Conversation

@montalvomiguelo
Copy link
Copy Markdown
Collaborator

@montalvomiguelo montalvomiguelo commented Mar 14, 2026

Closes #241

Summary by CodeRabbit

  • New Features
    • Added Vite 8 support for the page-reload and Shopify plugins; adjusted Vite 6.x compatibility constraints for the Shopify plugin while preserving support for Vite 5–7.
  • Chores
    • Updated release metadata to record patch version bumps for both plugins.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 14, 2026

Deploy Preview for bespoke-flan-5eacfc canceled.

Name Link
🔨 Latest commit 64ec13a
🔍 Latest deploy log https://app.netlify.com/projects/bespoke-flan-5eacfc/deploys/69b5cadf5f5f36000827d417

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 062a8ea8-8393-4d20-b344-016da856a105

📥 Commits

Reviewing files that changed from the base of the PR and between 4e9c00a and 64ec13a.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • packages/vite-plugin-shopify/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/vite-plugin-shopify/package.json

📝 Walkthrough

Walkthrough

Adds a changeset and updates peer dependency ranges in two packages to explicitly include Vite 8 alongside existing supported Vite versions.

Changes

Cohort / File(s) Summary
Vite peer dependency updates
packages/vite-plugin-page-reload/package.json, packages/vite-plugin-shopify/package.json
Extended peerDependencies.vite ranges to include ^8.0.0 (adjusted range syntax for vite-plugin-shopify).
Changeset documentation
.changeset/flat-results-warn.md
Added a changeset titled "Vite 8 Support" indicating patch bumps for vite-plugin-page-reload and vite-plugin-shopify.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Add vite 7 support #201: Modifies packages/vite-plugin-page-reload peerDependency to accept newer Vite versions — closely related dependency change.
  • Update dependencies #225: Updates packages/vite-plugin-shopify and associated changesets — overlaps with package and changelog edits.

Poem

🐰 I nibble code by moonlit light,
I hop and widen ranges just right.
A tiny line, a gentle shove,
Now Vite can dance eight steps above. 🥕✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add vite 8 support' is concise, clear, and directly summarizes the main change—extending peer dependency support for Vite 8.
Linked Issues check ✅ Passed The PR successfully implements the Vite 8 peer dependency updates requested in issue #241, adding ^8.0.0 support to both affected packages.
Out of Scope Changes check ✅ Passed All changes in the PR are directly scoped to adding Vite 8 support via peer dependency updates and the corresponding changeset file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vite-8
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/flat-results-warn.md:
- Line 6: Update the changeset heading currently written as "Vite 7 Support" to
accurately reflect the PR by changing it to "Vite 8 Support" (i.e., replace the
heading text "Vite 7 Support" with "Vite 8 Support" in the .changeset entry so
the title matches the actual change).

In `@packages/vite-plugin-shopify/package.json`:
- Line 35: The vite peer dependency range in package.json is too open-ended
because the `>=6.0.9` clause allows any future major; update the version
expression for the "vite" peer dependency to include an upper bound for the 6.x
series so it doesn't match 7.x+ unintentionally—e.g. replace the current string
value containing `>=6.0.9` with one that explicitly bounds 6.x like `">=5.4.12
<6.0.0 || >=6.0.9 <7.0.0 || ^7.0.0 || ^8.0.0"` so the 6.x range stops before
7.0.0 while preserving the intended 5.x, 7.x and 8.x compatibility.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ff7c6eb7-08f8-48e5-b25b-ef6b437b40cb

📥 Commits

Reviewing files that changed from the base of the PR and between bf227be and 82c7ecb.

⛔ Files ignored due to path filters (2)
  • packages/vite-plugin-shopify/test/__snapshots__/index.test.ts.snap is excluded by !**/*.snap
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .changeset/flat-results-warn.md
  • packages/vite-plugin-page-reload/package.json
  • packages/vite-plugin-shopify/package.json

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 14, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@montalvomiguelo montalvomiguelo merged commit 5786913 into main Mar 14, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Vite 8 to peerDependencies

2 participants