Skip to content

Add possibility to filter translations by key #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add possibility to filter translations by key #363

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
014551a
Add possibility to filter translations by key
lada May 15, 2020
cd94120
Make search case insensitive
lada May 15, 2020
f82284f
Add some margin under the search field
lada May 15, 2020
9a5e1f7
Fix row index update after key removal
lada May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion resources/views/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,26 @@
}
});

var rowsById = {};
$('.table tbody tr').each(function() {
var id = $(this).attr('id').toLowerCase();
rowsById[id] = $(this);
});

$('#search-field').keyup(function() {
var searchKey = $(this).val().toLowerCase();
Object.keys(rowsById).forEach(function(key) {
rowsById[key].toggle(!searchKey || key.includes(searchKey));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to replace key.includes(searchKey) with key.toUpperCase().includes(searchKey).
Otherwise very good. Good Job.

});
});

$("a.delete-key").click(function(event){
event.preventDefault();
var row = $(this).closest('tr');
var url = $(this).attr('href');
var id = row.attr('id');
$.post( url, {id: id}, function(){
delete rowsById[id.toLowerCase()];
row.remove();
} );
});
Expand Down Expand Up @@ -227,7 +241,10 @@
</div>
</form>
<hr>
<h4>Total: <?= $numTranslations ?>, changed: <?= $numChanged ?></h4>
<div class="row">
<h4 class="col-md-9">Total: <?= $numTranslations ?>, changed: <?= $numChanged ?></h4>
<p class="col-md-3"><input type="search" placeholder="Filter by key..." id="search-field" class="form-control" /></p>
</div>
<table class="table">
<thead>
<tr>
Expand Down