You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CSV import is no longer idempotent — re-importing the same file accumulates duplicate entries
mergeExpansions() was changed from a Map-based merge (which deduplicates by shortcut key) to a flatMap concatenation that emits every entry unconditionally. Before this PR, importing a CSV whose shortcuts already existed in the persisted list was safe to repeat: the Map ensured one entry per shortcut. Now, every import appends all rows unconditionally, so importing the same CSV twice doubles every entry, importing it three times triples them, and so on. All duplicated entries are written to storage and then to /textExpansions.txt via TextExpansionManager.setupTextExpansions.
The call site at line 191 also swapped argument order (from mergeExpansions(imported, existing) to mergeExpansions(existing, imported)), which is correct for the new signature but means any merge logic that previously gave imported entries priority over existing ones (last-write-wins via Map) now gives existing entries first position in the output array.
Addressed the CSV import regression in 57586c2. Import now deduplicates only exact (shortcut, text) pairs, so re-importing the same file is idempotent while same-shortcut snippets with different bodies are still preserved. Added a regression test that imports the same CSV twice and verifies only distinct pairs remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan