Skip to content

refactor: minimize suggestion menu host markup#334

Open
bartekplus wants to merge 1 commit intomasterfrom
codex/minimize-suggestion-menu-host
Open

refactor: minimize suggestion menu host markup#334
bartekplus wants to merge 1 commit intomasterfrom
codex/minimize-suggestion-menu-host

Conversation

@bartekplus
Copy link
Owner

@bartekplus bartekplus commented Mar 21, 2026

Summary

  • minimize the shadow-path suggestion popup host to an anonymous div with only a generated id
  • move early-Tab visibility checks from host attributes onto input-side state
  • update unit and e2e helpers to resolve menu hosts from managed inputs, including shadow-root cases

Test Plan

  • bun test tests/SuggestionMenuView.test.ts tests/SuggestionMenuPresenter.test.ts tests/EarlyTabAcceptMainWorldBridge.test.ts tests/SuggestionManagerRuntime.test.ts tests/SuggestionManager.test.ts
  • bun run test:e2e
  • bun run check (blocked by pre-existing TypeScript errors in ManualAttachUiManager, SuggestionManagerRuntime, and SuggestionTextEditService)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant