Skip to content

feat: add client_bin benchmark variable #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meyer9 merged 1 commit into from
Feb 10, 2026
Merged

feat: add client_bin benchmark variable #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions runner/benchmark/benchmark.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ func NewParamsFromValues(assignments map[string]interface{}) (*types.RunParams,
} else {
return nil, fmt.Errorf("invalid node type %s", v)
}
case "client_bin":
if vStr, ok := v.(string); ok {
params.ClientBinPath = vStr
} else {
return nil, fmt.Errorf("invalid client bin %s", v)
}
case "validator_node_type":
if vStr, ok := v.(string); ok {
params.ValidatorNodeType = vStr
Expand Down
15 changes: 15 additions & 0 deletions runner/network/types/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ type RunParams struct {

// NodeArgs are the arguments to be passed to the node binary.
NodeArgs []string

// ClientBinPath is an optional override for the client binary path.
ClientBinPath string
}

func (p RunParams) ToConfig() map[string]interface{} {
Expand Down Expand Up @@ -115,6 +118,18 @@ func (p RunParams) ToConfig() map[string]interface{} {
// ClientOptions applies any client customization options to the given client options.
func (p RunParams) ClientOptions(prevClientOptions config.ClientOptions) config.ClientOptions {
prevClientOptions.NodeArgs = p.NodeArgs
if p.ClientBinPath != "" {
switch p.NodeType {
case "reth":
prevClientOptions.RethBin = p.ClientBinPath
case "geth":
prevClientOptions.GethBin = p.ClientBinPath
case "builder":
prevClientOptions.BuilderBin = p.ClientBinPath
case "base-reth-node":
prevClientOptions.BaseRethNodeBin = p.ClientBinPath
}
}
return prevClientOptions
}

Expand Down