-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add visibility config field (public/private) to CLI #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
base44-os-gremlins
wants to merge
6
commits into
main
Choose a base branch
from
feat/visibility-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+192
−3
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
899d5c8
feat: add visibility config field (public/private) to CLI
github-actions[bot] 71ea0f5
fix: use PUT /api/apps/{id} for visibility update and correct private…
netanelgilad 9549a6c
merge: resolve conflict with main in api.ts
netanelgilad 6df88cf
feat: add workspace visibility level
55d6b82
Merge branch 'main' into feat/visibility-config
netanelgilad 101b4fd
fix: format long line in VisibilitySchema to pass Biome lint
netanelgilad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { ProjectConfigSchema } from "@/core/project/schema.js"; | ||
|
|
||
| describe("ProjectConfigSchema visibility field", () => { | ||
| it('accepts visibility: "public"', () => { | ||
| const result = ProjectConfigSchema.safeParse({ | ||
| name: "My App", | ||
| visibility: "public", | ||
| }); | ||
| expect(result.success).toBe(true); | ||
| if (result.success) { | ||
| expect(result.data.visibility).toBe("public"); | ||
| } | ||
| }); | ||
|
|
||
| it('accepts visibility: "private"', () => { | ||
| const result = ProjectConfigSchema.safeParse({ | ||
| name: "My App", | ||
| visibility: "private", | ||
| }); | ||
| expect(result.success).toBe(true); | ||
| if (result.success) { | ||
| expect(result.data.visibility).toBe("private"); | ||
| } | ||
| }); | ||
|
|
||
| it("accepts omitted visibility (no-op, field is undefined)", () => { | ||
| const result = ProjectConfigSchema.safeParse({ name: "My App" }); | ||
| expect(result.success).toBe(true); | ||
| if (result.success) { | ||
| expect(result.data.visibility).toBeUndefined(); | ||
| } | ||
| }); | ||
|
|
||
| it('accepts visibility: "workspace"', () => { | ||
| const result = ProjectConfigSchema.safeParse({ | ||
| name: "My App", | ||
| visibility: "workspace", | ||
| }); | ||
| expect(result.success).toBe(true); | ||
| if (result.success) { | ||
| expect(result.data.visibility).toBe("workspace"); | ||
| } | ||
| }); | ||
|
|
||
| it("rejects invalid visibility value with a clear error", () => { | ||
| const result = ProjectConfigSchema.safeParse({ | ||
| name: "My App", | ||
| visibility: "restricted", | ||
| }); | ||
| expect(result.success).toBe(false); | ||
| if (!result.success) { | ||
| const message = result.error.issues[0]?.message ?? ""; | ||
| expect(message).toMatch( | ||
| /Invalid visibility value|Invalid enum value|public.*private/i, | ||
| ); | ||
| } | ||
| }); | ||
| }); |
4 changes: 4 additions & 0 deletions
4
packages/cli/tests/fixtures/with-visibility/base44/.app.jsonc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // Base44 App Configuration | ||
| { | ||
| "id": "test-app-id" | ||
| } |
4 changes: 4 additions & 0 deletions
4
packages/cli/tests/fixtures/with-visibility/base44/config.jsonc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "name": "Visibility Test Project", | ||
| "visibility": "public" | ||
| } |
11 changes: 11 additions & 0 deletions
11
packages/cli/tests/fixtures/with-visibility/base44/entities/Item.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "name": "Item", | ||
| "type": "object", | ||
| "properties": { | ||
| "title": { | ||
| "type": "string", | ||
| "description": "Item title" | ||
| } | ||
| }, | ||
| "required": ["title"] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we also want to support this somewhere son the create / link commands?
Do we want to support this config in our templates?