Conversation
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/cli@0.0.47-pr.441.3070a4fPrefer not to change any import paths? Install using npm alias so your code still imports npm i "base44@npm:@base44-preview/cli@0.0.47-pr.441.3070a4f"Or add it to your {
"dependencies": {
"base44": "npm:@base44-preview/cli@0.0.47-pr.441.3070a4f"
}
}
Preview published to npm registry — try new features instantly! |
Collaborator
Author
|
@artemdemo I wonder what do you think about this. moving the runTask to be injected from the CLIContext.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Description
This PR refactors
runTaskfrom a single module-level function into a factory pattern with two implementations:createInteractiveRunTask()(uses a clack spinner) andcreateSimpleRunTask(log)(uses the logger). The chosen implementation is created at startup based on TTY detection and injected intoCLIContext, so commands now receiverunTaskvia dependency injection rather than importing it directly. This also fixes non-interactive environments where the spinner was previously used even when stdout was not a TTY.Related Issue
None
Type of Change
Changes Made
RunTaskFntype and replaced the singlerunTaskexport withcreateInteractiveRunTask()andcreateSimpleRunTask(log)factory functions inrunTask.tsrunTask: RunTaskFnfield toCLIContextand removedrunTaskfrom theutils/index.tsbarrel exportrunTaskimplementation incli/index.tsbased on TTY detection (isNonInteractive) and injected it intoCLIContextrunTaskfromCLIContextinstead of importing it directlyTesting
npm test)Checklist
docs/(AGENTS.md) if I made architectural changesAdditional Notes
The
createSimpleRunTaskimplementation logs the start message vialog.info, progress updates vialog.info, success vialog.success, and errors vialog.error— mirroring the spinner lifecycle for non-interactive consumers.🤖 Generated by Claude | 2026-03-24 00:00 UTC