docs: expose serverUrl for local development#139
Conversation
Remove @internal tag from serverUrl and add JSDoc with description, example, and default value so it appears in the SDK reference docs. Made-with: Cursor
Remove the process.env example that doesn't work in Vite and simplify the description to be environment-agnostic. Made-with: Cursor
|
Claude finished @wixysam's task —— View job Code Review for PR #139: docs: expose serverUrl for local developmentI've reviewed the changes to expose the ✅ Code Quality and Best PracticesThe changes follow excellent documentation practices:
✅ No Bugs or Issues DetectedThe changes are purely documentation-related and don't introduce any functional issues:
✅ Performance ConsiderationsNo performance impact - these are documentation-only changes that affect TypeDoc generation but not runtime behavior. ✅ Security ConsiderationsThe changes are security-neutral:
📝 Test CoverageThe test plan is appropriate for documentation changes:
💡 Minor Suggestions
SummaryThis is a well-crafted documentation improvement that makes the SDK more developer-friendly by exposing an important configuration option. The framework-agnostic approach is particularly good, as it avoids assumptions about the user's build environment. The changes are minimal, focused, and achieve the stated goal effectively. Recommendation: Approve ✅ |
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/sdk@0.8.20-pr.139.6d44627Prefer not to change any import paths? Install using npm alias so your code still imports npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.20-pr.139.6d44627"Or add it to your {
"dependencies": {
"@base44/sdk": "npm:@base44-preview/sdk@0.8.20-pr.139.6d44627"
}
}
Preview published to npm registry — try new features instantly! |
Summary
@internaltag fromserverUrlinCreateClientConfigso it appears in generated SDK reference docsprocess.envexample that breaks in Vite)Related: base44-dev/mintlify-docs PR for the local development documentation.
Test plan
npm run create-docs-localgenerates docs withserverUrlvisible on thecreateClientreference pageMade with Cursor