fix: compilation errors, path bugs, and full test coverage#1
Open
base44-os-gremlins[bot] wants to merge 1 commit intomainfrom
Open
fix: compilation errors, path bugs, and full test coverage#1base44-os-gremlins[bot] wants to merge 1 commit intomainfrom
base44-os-gremlins[bot] wants to merge 1 commit intomainfrom
Conversation
- Fix PartData unresolved reference by importing io.ktor.http.content.*
- Add `internal constructor` to all module classes that take the internal
Base44HttpClient, preventing public API exposure of internal types
- Fix UsersModule.inviteUser path: add /runtime/ to match JS SDK
- Fix AppLogsModule.list path: use /app-logs/{appId} (matches JS SDK)
- Add Gradle wrapper (8.10) so the project builds without system Gradle
- Add 16 new MockEngine-based tests covering IntegrationsModule,
CoreIntegrations, AgentsModule, AppLogsModule, and UsersModule
- All 36 JVM tests pass (0 failures, 0 errors)
Relates to: https://github.com/base44-dev/gremlins/issues/867
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PartDataunresolved reference fixed by addingimport io.ktor.http.content.*toHttpClient.ktEntitiesModule,EntityHandler,AuthModule,AgentsModule,AppLogsModule,FunctionsModule,IntegrationsModule,CoreIntegrations,UsersModule) had constructors markedinternal constructorto prevent the public API from exposing the internalBase44HttpClienttypeUsersModule.inviteUserpath corrected to/apps/{appId}/runtime/users/invite-user(matching JS SDK);AppLogsModule.listpath corrected to/app-logs/{appId}(matching JS SDK)gradle/wrapper/andgradlew(Gradle 8.10) so the project builds without requiring a system Gradle installationAdditionalModuleTests.ktcoversIntegrationsModule,CoreIntegrations,AgentsModule,AppLogsModule, andUsersModuleusingMockEngine(no network required)Test Results
36 JVM tests — 0 failures, 0 errors
EntitiesModuleTestHttpClientTestAgentsModuleTestIntegrationsModuleTestCreateClientTestAuthModuleTestAppLogsModuleTestUsersModuleTestFunctionsModuleTestTest plan
./gradlew jvmTestpasses locally (36/36)Relates to: https://github.com/base44-dev/gremlins/issues/867
🤖 Generated with Claude Code