Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"X-App-Id" to config.appIdfrombaseHeadersincreateClient(Base44Client.kt)testXAppIdHeaderSent→testCustomHeadersForwardedwith a generic custom header, since the test was validating header forwarding inBase44HttpClient(still valid behavior, just not X-App-Id specifically)Context
Part of the platform-wide removal of the legacy X-App-Id header: base44-dev/gremlins#871
App identity is determined from URL path parameters (
/api/apps/{app_id}/...). The header was never read by the backend for any current routes.Test plan
testCustomHeadersForwarded)