Mobile app / Prepare webviews #2178
Open
+291
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menu, back buttons, bottom bar
... in card perma
* mobile-app/scoped-styles: Replace android and ios css layers with platform layer Change how show-on-native works Use the correct css layers for Android and iOS
... when the container is larger than needed
... to pick up the url change and <head> update
Contributor
|
Good stuff! Before you merge, I'm going to pitch in and make a small change to get this text to be full width. It's in a grid cell right now, and I think just dropping it onto its own row is the way to go. 
|
Contributor
|
That's better:
|
Contributor
Author
|
Sweet! Thanks @andyra |
Contributor
Author
|
I'm excluding mobile devices from loading the navigable list controller. It's a keyboard thing. |
* main: (107 commits) Document the new sign in method Replace handle_ naming Use same constant for fake magic links Replace FakeMagicLink with a temporary object Tidy up session_token Clean up interfaces Split tests by controller or responsibility Simplify auth logic Fix due to unit test when creating with invalid emails Restore sessions_controller test on creating invalid email address Move magic link api tests to their own files Rename test to clarify what they're about Cleanup session creation Update to always return a pending auth token for JSON responses. Update API test for cross code Change test expectation on single tenant mode account creation Add unit tests for the new endpoints Pass a server token when creating a magic link via API Simplify code a bit Simplify session create logic for both html and json ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2177 put the structure in place, this PR actually makes some changes targeted at the Android and iOS apps.
I'm applying changes to mobile web as well so let's discuss if we do want it that way or not.
Desktop should look unchanged.
First stop, the header
with bigger icon buttons and actions always above title 👇
Next, card perma
with a bit less background and a horizontal layout for the column picker 👇
The column picker is automatically centered on the current column, so when the page loads, you're getting this 👇
Pins
making /my/pins usable. It's only used by the native apps as we have dedicated tabs instead of alway-on-screen-stacks 👇
This is mostly done by moving existing styles.
For example, instead of applying some styles based on a .card being in a .tray:
apply based on being in a .tray__item:
Or instead of applying some style based on being a .tray__item in .tray--pins:
apply based on being a .tray__item--pin:
This allows us to pick up the tray formatting of pinned tickets in /my/pins, like we do with the tray formatting of notifications in /notifications
Search
making /search usable. Like /my/pins it's only used by the native apps, search being its own tab instead of an alway-on-screen bar 👇
I also took the liberty to slightly alter search results in the bottom bar 👇
Again, this is mostly done by repurposing existing stuff.
Web views
the rest is hiding stuff we don't want in the native apps 👇