-
Notifications
You must be signed in to change notification settings - Fork 785
Add hotkeys for triaging cards in columns #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hover to select items
monorkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I found a few small bugs and left a comment by the code that, I think, causes it.
There is one more bug which I couldn't pin point. Cards don't update when you move them from "Not now" to "Done", but the column does and the card moves.
screenrecording-2025-12-22_17-53-48.mp4
The hotkeys shouldn't work in the Not Now and Done columns because it really doesn't make sense to assign cards in those columns nor does it really make sense to move, for example, from Not Now to Done. I'll make sure those are properly disabled in the UI. |
Avoids situations where the hotkey could be triggered on the board view
Hi @monorkin, I just found a bug where moving a card from 'not now' to 'done' didn't destroy the not_now record, like it does when a card is resumed. This prevented it showing in "done" and "indexed_by=closed" filters. This could be why the cards in your screen recording are having strange behaviour. PR is here #2237 |
|
@dilberryhoundog that seems unrelated to this PR. I'll take a look at your PR in a bit. |
monorkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jzimdars Looks good now
@monorkin Thank you. Yes it was unrelated. Bug: Card duplication when closing from Not NowRoot CauseWhen closing a card from "Not Now" using the Fix--- a/app/controllers/concerns/card_scoped.rb
+++ b/app/controllers/concerns/card_scoped.rb
@@ -21,6 +21,7 @@ module CardScoped
def capture_card_location
@source_column = @card.column
@was_in_stream = @card.awaiting_triage?
+ @was_postponed = @card.postponed?
end--- a/app/views/cards/closures/create.turbo_stream.erb
+++ b/app/views/cards/closures/create.turbo_stream.erb
@@ -4,6 +4,8 @@
<%= turbo_stream.replace(dom_id(@source_column), partial: "boards/show/column", method: :morph, locals: { column: @source_column }) %>
<% elsif @was_in_stream %>
<%= turbo_stream.replace("the-stream", partial: "boards/show/stream", method: :morph, locals: { board: @card.board, page: @page }) %>
+<% elsif @was_postponed %>
+ <%= turbo_stream.replace("not-now", partial: "boards/show/not_now", method: :morph, locals: { board: @card.board }) %>
<% end %> |
Hover or arrow to select cards in active columns on a board, then use hotkeys on them:
[Move to Not Now.MAssign to Me,]Move to Done