Skip to content

Remove unused cards__heading styles #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afurm wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −41
Open

Remove unused cards__heading styles #2223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions app/assets/stylesheets/card-columns.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,44 +408,6 @@
}
}

/* TODO: I think this is legacy now? */
.cards__heading {
display: flex;
font-size: var(--text-medium);
inset-block-start: 0;
justify-content: center;
margin-block-start: 1px;
margin-inline: -8px; /* enough to cover card shadows, but avoid overlapping bubbles */
padding-block: var(--cards-gap) 0;
position: sticky;
z-index: 3;

/* Cover bubbles and cards on small viewports */
@media (max-width: 639px) {
margin-inline: calc(-1 * var(--cards-gap) - var(--main-padding));
}

&, .cards__filter {
font-weight: bold;
text-transform: uppercase;
}

.cards__filter {
--filter-block-padding: 0.5rem;

background-color: var(--color-canvas);
border-radius: 99rem;
inline-size: auto;
margin-block: calc(-1 * var(--filter-block-padding));
padding-block: var(--filter-block-padding);
}

dialog {
font-weight: normal;
text-transform: none;
}
}

/* Override card styles within columns
/* ------------------------------------------------------------------------ */

Expand Down
3 changes: 0 additions & 3 deletions app/assets/stylesheets/drag_and_drop.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,5 @@
transition: background-color 200ms;
z-index: 1;

.cards__heading {
background-color: transparent;
}
}
}