Add Image Upload/Attachment Optimization#691
Open
Matarim wants to merge 3 commits intobasecamp:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I brought this idea here: Idea Discussion, but the goal of this work is to provide the ability to optimize images that are attached to Lexxy form.
Can this work be done elsewhere:
This work can be done in an initializer in your project that patches the ActiveStorage::Attachment to pull down the attached images loop through and modify the storage object and the blob. This requires modifying the HTML to point to the new key after conversion and honestly would not be optimal for heavy usage, but is possible.
Why I think it belongs here:
Doing the work at the time of the preview front-loads the optimization process and gives an easier way to handle modifying the optimization based on where it is being used by simply changing the configuration.
I'm attaching an example of how to use below, but that is also available in the discussion brought up before.
Additional consideration and thoughts on restricting optimization on certain file types like svg may be a good plan here, and I'm open to discussion and ideas on how to better handle image file types that shouldn't be converted to a different format/quality.