Conversation
|
This is exciting! I appreciate this is draft but I tried it and found an issue, just in case you hadn't spotted it:
Now when you edit this content, Lexxy merges all 3 images into one gallery. If you happened to have a paragraph of text between the gallery and the standalone image, it gets deleted. Also noticed that when adding a gallery at the end of the editor, the cursor appears to be positioned beyond the boundary of |
|
Thanks for checking it out so early!
I'd have expected http://lexxy.localhost:3000/sandbox/images to have the same issue with the gallery followed by the images. This is part of wrapping the entire content with
@zoltanhosszu fancy having a peek? |
a6cfbb0 to
c5549c3
Compare
77c9baf to
5b47b4f
Compare
5b47b4f to
a36f0f1
Compare
477fc94 to
716c4ba
Compare
a36f0f1 to
d62f967
Compare
d62f967 to
9639ffd
Compare
716c4ba to
4ce151b
Compare
9639ffd to
97afbb9
Compare
4ce151b to
db2bcbe
Compare
Introduce ImageGalleryNode and accompanying extension. The gallery uses ElementNode to give Lexical selection, overriden for node-level selection. `contents.uploadFiles` accepts multiple files and will handle gallery insertion/promotion and sort non-galleryable files. Co-authored-by: Zoltan Hosszu <zoltan@37signals.com>
Utility class to handle upload scenarios with an OO pattern
db2bcbe to
4588c13
Compare
97afbb9 to
127ee90
Compare
|
This will be a huge feature. Thanks for working on this @samuelpecher |
Drop-in replacement for Trix image galleries
ImageGalleryNodeimplementingElementNodeoverriding selection to force a NodeSelection at all timesAttachmentExtensionconditionally loaded when attachments are enabledContrasting with Trix, selection in a gallery is always on a node, not in-between. Galleries can be split with Enter and Backspace Del behave as expected