Remove wrapping <div>, clean up & refactor#724
Open
samuelpecher wants to merge 8 commits intosandbox-improvementsfrom
Open
Remove wrapping <div>, clean up & refactor#724samuelpecher wants to merge 8 commits intosandbox-improvementsfrom
samuelpecher wants to merge 8 commits intosandbox-improvementsfrom
Conversation
Commands execute in an `editor.update` context already
Simplify the code since `editorState.read()` can return a value
Remove `editor.update()` call as the `node` param suggests an existing update context.
packagethief
approved these changes
Feb 10, 2026
Member
packagethief
left a comment
packagethief
left a comment
There was a problem hiding this comment.
Looks great, @samuelpecher
|
|
||
| // Configure Stimulus development experience | ||
| application.debug = true | ||
| application.debug = false |
samuelpecher
force-pushed
the
clean-up
branch
from
7398733 to
a361148
Compare
ActionText galleries use `<div>`, and would cause any image to become wrapped in a gallery. Rather than wrap the entire value in a `<div>` and wrap text nodes which cannot be attached to the root node in a `<p>`
samuelpecher
force-pushed
the
clean-up
branch
from
a361148 to
dcad3ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<div>wrapping, both in the rails helper and in js API'sset value()editor.update()to not create a new update loopcc @packagethief