Conversation
samuelpecher
force-pushed
the
organize-extensions
branch
from
5e6067e to
5c8eb7a
Compare
samuelpecher
force-pushed
the
clean-up
branch
from
7398733 to
a361148
Compare
Move pure lexical extensions into a separate folder to distinguish them
Remove highlighter as it no longer controlled configuration and was a just an uneeded facade for the dispatcher to the TOGGLE_HIGHLIGHT_COMMAND
samuelpecher
force-pushed
the
organize-extensions
branch
from
5c8eb7a to
ff05d38
Compare
samuelpecher
force-pushed
the
clean-up
branch
from
a361148 to
dcad3ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce various mechanisms to use
LexxyExtension:editor.highlighter&HighlightExtensionTrixContentLexicalExtensionTablesExtensionThis also uses
mergeExtensionin theregisterlifecycle step of extension registration to ensure handlers are unregistered on editordispose.This allows the removal of conditional extension loading code in
editor.jsas extensions define themselves whether to loadcc @packagethief