Open
Conversation
Dispatch lexxy:upload-start, lexxy:upload-progress, and lexxy:upload-end events on the editor element during file uploads, letting consumers react to the upload lifecycle (e.g., disabling submit buttons, showing progress). Closes basecamp#735 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MatheusRich
force-pushed
the
upload-lifecycle-events
branch
from
79801ff to
eeead96
Compare
MatheusRich
commented
Feb 17, 2026
| } | ||
|
|
||
| get #editorElement() { | ||
| return this.editor.getRootElement().parentElement |
Author
There was a problem hiding this comment.
I don't love this. We could instead invert the dependency here and pass editorElement instead of editor?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dispatches lexxy:upload-start, lexxy:upload-progress, and lexxy:upload-end events on the editor element during file uploads. This lets consumers react to the upload lifecycle — for example, disabling submit buttons or showing custom progress UI.
Events bubble up from the element with relevant detail (file, progress, error).
Closes #735