Create a ruby gem package "action_text-trix" #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
flavorjones
force-pushed
the
flavorjones/package-in-ruby-gem
branch
from
c897168 to
e3edf34
Compare
|
Looks great @flavorjones! Could we update the release script to sync, build and push the gem? I guess either by adding a command to the release script in package.json, or adding |
|
@djmb Done! |
Directory "action_text-trix" contains a gem that is a Rails engine providing Trix assets (js and css files). When cutting a release, there is a rake task "sync" provided by action_text-trix/Rakefile to copy Trix files from the build directory into the gem directory. See action_text-trix/README.md for more information.
flavorjones
force-pushed
the
flavorjones/package-in-ruby-gem
branch
from
cc78c4e to
8994151
Compare
|
In a later commit, I'll add an integration test of action text (once this is being used upstream). |
|
👏 Nice work! I would have went with |
|
Rails PR is rails/rails#55058 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: rails/rails#54148
Directory "action_text-trix" contains a gem that is a Rails engine providing Trix assets (js and css files).
When cutting a release, there is a rake task "sync" provided by action_text-trix/Rakefile to copy Trix files from the build directory into the gem directory. See action_text-trix/README.md for more information.
A note on naming: "trix" is already taken, as is "trix-rails", "trix_rails", "trix_on_rails", and "trix-gem". But also, this gem should really only ever be used as an implicit dependency of Rails and Action Text, so naming is less important than it otherwise might be.
I've emailed the owner of "trix" to see if they would be willing to give up the name, but at this point I think I've decided it doesn't matter a whole lot.
The accompanying Rails PR will look something like this: flavorjones/rails#1