-
Notifications
You must be signed in to change notification settings - Fork 129
Article app (with Wallabag and Readeck support) #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Ideally we'd also put a line on the left to more clearly mark it as a blockquote, but this will at least make it easier to distinguish blockquotes from other text.
This bottom bar is also useful for the articles view.
| // This is a terrible idea, but there doesn't seem to be an alternative that | ||
| // doesn't involve asking the user to manually create an API client and copying | ||
| // over the client ID and secret. Since the Android app does something similar, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both Chrome extension and iOS app actually require creating an API client manually, so most of the users are probably used to that already.
(Sorry for a random comment.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it's still a terrible user experience. Especially on an e-reader where you can't easily copy-paste text. Ideally we'd present a QR code for the user to scan using the Wallabag app, or a code to enter on the website, but this is the best we can do with the current API.
For background, see this bug report that hasn't been fixed in over 7 years: wallabag/wallabag#2800 (TL;DR: alternatives were proposed but nobody took the time to write a better authentication API).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you're right, it'd be a nightmare to type all the codes on the device.
c58e215 to
6a3c2fa
Compare
First version of built-in Wallabag support.
There are a number of things that aren't quite there yet:
* All articles are always downloaded. Ideally, only new unread
articles would be downloaded.
* The epubs downloaded from Wallabag aren't great, they have some
noise that I'd rather avoid. We might want to create our own by
converting them from HTML to custom epubs.
|
Hi, out of interest, what is the status and usability of this PR? I'd very much like to use it with Readeck. |
|
I've been using it, and it works fine, but I've recently switched to Instapaper instead since that has better integration on my Kobo. Building this yourself is somewhat involved, but I managed to do it: #395 Against my expectations, my 10 year old Kobo actually got a firmware update to support Instapaper instead of Pocket! Among so many companies abandoning their products after 2-3 years, I think that's really good. So now I've actually just switched to Instapaper, and am no longer using Plato with Readeck support. For anybody wanting to support these services in Plato, feel free to take my code and do whatever you want with it. Would love to see it integrated in Plato at some point, but I'm unlikely to work on it in the future. |
First version of built-in Wallabag support, see #400.
There are a number of things that aren't quite there yet:
(This PR also includes #397, I can remove it but added it for my own convenience).