WANFEI Xiaomi Flower compatibility and non blocking poll demo#146
Open
afer92 wants to merge 5 commits intobasnijholt:masterfrom
Open
WANFEI Xiaomi Flower compatibility and non blocking poll demo#146afer92 wants to merge 5 commits intobasnijholt:masterfrom
afer92 wants to merge 5 commits intobasnijholt:masterfrom
Conversation
Add non blocking poll demo
Wanfei compatibility and non blocking pool demo
Collaborator
|
So I understand you want to extend the range of MAC addresses to support other devices. I see the benefits of that. What's the purpose of demo_timeout.py? At first glance the code looks quite similar to demo.py except for the timout parameter. Why not integrate the feature in demo.py? |
|
I've got a new MiFlora, too. My old ones MACs starting with C4:7C:8D, the new one with 80:EA:CA, so I think that should updated in demo.py. |
Owner
|
I have just added that in e62f0cd. |
Author
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.