Fix for Firmware 3.6.6 Mi Flora Max#172
Open
DarkByteZero wants to merge 1 commit intobasnijholt:masterfrom
Open
Fix for Firmware 3.6.6 Mi Flora Max#172DarkByteZero wants to merge 1 commit intobasnijholt:masterfrom
DarkByteZero wants to merge 1 commit intobasnijholt:masterfrom
Conversation
first fix for Mi Flora Max
DarkByteZero
changed the title
Author
|
Fixes #171 |
DarkByteZero
commented
Aug 8, 2022
| datetime.now() - self._cache_timeout + timedelta(seconds=300) | ||
| ) | ||
| return | ||
| time.sleep(1) # without this, the previous write_handle is done after we read the data |
Author
There was a problem hiding this comment.
That's a poor fix, I know that. But I don't really know much about Python or the Bluethooth libaray. It should be checked whether the handle has already been written.
DarkByteZero
commented
Aug 8, 2022
| # With this cleaning, the cache is always empty. | ||
|
|
||
| #if self._firmware_version >= "2.6.6": | ||
| # if sum(self._cache[10:]) == 0: |
Author
There was a problem hiding this comment.
Why are the bytes 11-16 important?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first fix for Mi Flora Max