Open
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the VClaim SEP approval request to use form-URL-encoded content type, derives response metadata before decrypting, accepts both 200 and 201 as success codes, adds a new request field, and documents the change in the changelog. Sequence diagram for updated SEP approval request flowsequenceDiagram
participant Admin
participant BpjsService
participant BpjsServer
Admin->>BpjsService: post(url, request_initial_JSON, consid, secretkey, userkey, tStamp)
Note over Admin,BpjsService: HTTP header Content-Type: application/x-www-form-urlencoded
BpjsService->>BpjsServer: POST approval request (body is JSON string)
BpjsServer-->>BpjsService: HTTP response (JSON)
BpjsService-->>Admin: raw JSON string output
Admin->>Admin: json_decode(output) to data
Admin->>Admin: code = data.metaData.code
Admin->>Admin: message = data.metaData.message
Admin->>Admin: stringDecrypt(key, data.response)
Admin->>Admin: decompress decrypted response (if not empty)
alt code is 200 or 201
Admin->>Admin: Build follow-up request with noKartu, tglSep, jnsPelayanan, jnsPengajuan, keterangan, user
Admin->>BpjsService: post(url, followup_request_JSON, consid, secretkey, userkey, tStamp)
Note over Admin,BpjsService: HTTP header Content-Type: application/x-www-form-urlencoded
BpjsService->>BpjsServer: POST follow-up approval request
BpjsServer-->>BpjsService: HTTP response
BpjsService-->>Admin: raw JSON string output
else code is not 200 or 201 or response invalid
Admin->>Admin: Build error response with default message
end
Flow diagram for SEP approval success handling (codes 200 and 201)flowchart TD
A[Receive BPJS response output] --> B[Decode JSON to data]
B --> C{Has metaData and response?}
C -- No --> D[Set error response ADA KESALAHAN ATAU SAMBUNGAN KE SERVER BPJS TERPUTUS]
C -- Yes --> E[Read code and message from data.metaData]
E --> F[Decrypt response with stringDecrypt]
F --> G[Decompress decrypted response if not empty]
G --> H{code is 200 or 201}
H -- No --> D
H -- Yes --> I[Build follow-up request t_sep with noKartu, tglSep, jnsPelayanan, jnsPengajuan, keterangan, user]
I --> J[Set header Content-Type: application/x-www-form-urlencoded]
J --> K[JSON-encode follow-up request]
K --> L[Send POST to BPJS Sep/aprovalSEP via BpjsService]
L --> M[Process follow-up response as needed]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- The
Content-Typeheader is now set toapplication/x-www-form-urlencodedwhile the payload is still JSON-encoded viajson_encode($request); consider either URL-encoding the body or reverting the header toapplication/jsonto keep them consistent with BPJS expectations. - By moving
$code = $data['metaData']['code'];and$message = $data['metaData']['message'];before theif ($data && isset($data['metaData']))guard,$code/messagemay be accessed when$dataormetaDatais missing, risking notices; consider keeping these assignments inside the guarded block or adding additional checks. - The new
$_POST['jnsPengajuan']access is not validated, so if the field is missing it will trigger an undefined index notice; consider checking for its presence or providing a sensible default before using it.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `Content-Type` header is now set to `application/x-www-form-urlencoded` while the payload is still JSON-encoded via `json_encode($request)`; consider either URL-encoding the body or reverting the header to `application/json` to keep them consistent with BPJS expectations.
- By moving `$code = $data['metaData']['code'];` and `$message = $data['metaData']['message'];` before the `if ($data && isset($data['metaData']))` guard, `$code`/`message` may be accessed when `$data` or `metaData` is missing, risking notices; consider keeping these assignments inside the guarded block or adding additional checks.
- The new `$_POST['jnsPengajuan']` access is not validated, so if the field is missing it will trigger an undefined index notice; consider checking for its presence or providing a sensible default before using it.
## Individual Comments
### Comment 1
<location path="plugins/vclaim/Admin.php" line_range="2809-2810" />
<code_context>
- // echo $data;
- print_r(htmlspecialchars($output, ENT_QUOTES | ENT_SUBSTITUTE, 'UTF-8'));
+ // print_r(htmlspecialchars($output, ENT_QUOTES | ENT_SUBSTITUTE, 'UTF-8'));
+ $code = $data['metaData']['code'];
+ $message = $data['metaData']['message'];
if ($data && isset($data['metaData'])) {
</code_context>
<issue_to_address>
**issue (bug_risk):** Accessing `$data['metaData']` before checking it exists can trigger notices and leave `$code`/`$message` undefined.
`$code` and `$message` are read before `if ($data && isset($data['metaData']))`. If `json_decode` fails or `metaData` is absent, this will emit notices and leave `$code` undefined when evaluated in `if ($code == 200 or $code == 201)`. Please assign `$code`/`$message` inside the `if ($data && isset($data['metaData']))` block and provide a sensible default for `$code` in the error path.
</issue_to_address>
### Comment 2
<location path="CHANGELOG.md" line_range="25" />
<code_context>
+## [2026-04-08]
+
+### Changed
+- VClaim: Perubahan header dan body request pada aproval SEP
\ No newline at end of file
</code_context>
<issue_to_address>
**issue (typo):** Consider correcting the typo "aproval" to "approval".
This occurs in the VClaim changelog line: `Perubahan header dan body request pada aproval SEP`.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+2809
to
+2810
| $code = $data['metaData']['code']; | ||
| $message = $data['metaData']['message']; |
Contributor
There was a problem hiding this comment.
issue (bug_risk): Accessing $data['metaData'] before checking it exists can trigger notices and leave $code/$message undefined.
$code and $message are read before if ($data && isset($data['metaData'])). If json_decode fails or metaData is absent, this will emit notices and leave $code undefined when evaluated in if ($code == 200 or $code == 201). Please assign $code/$message inside the if ($data && isset($data['metaData'])) block and provide a sensible default for $code in the error path.
| ## [2026-04-08] | ||
|
|
||
| ### Changed | ||
| - VClaim: Perubahan header dan body request pada aproval SEP No newline at end of file |
Contributor
There was a problem hiding this comment.
issue (typo): Consider correcting the typo "aproval" to "approval".
This occurs in the VClaim changelog line: Perubahan header dan body request pada aproval SEP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Adjust approval SEP request handling for VClaim BPJS integration.
Bug Fixes:
Enhancements:
Documentation: