Open
Conversation
pombredanne
reviewed
Jan 17, 2023
Collaborator
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! can you add tests too?
The fact that we eval FALSE and TRUE to themselves may be a design decision, so getting tests is important!
Collaborator
|
gentle ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two problems.
First is that the classes
_TRUEand_FALSEdon't accept keyword arguments for the__call__function. This means that when evaluating model with constants it raises a similar exception to this:After adding the keyword arguments the second problem is that the
__call__magic function returnsselfinstead of the boolean value. This leads to exception similar to this:Code used to reproduce both bugs: