Conversation
norgevz
left a comment
norgevz
left a comment
There was a problem hiding this comment.
Could you add a description on the PR outlining all the changes produced here?
Done |
model/main.py
Outdated
| all_token_content = renderer.wrap_all_token_details(all_token_content) | ||
| content += all_token_content | ||
| model = renderer.get_model(country) | ||
| if model is not None: |
There was a problem hiding this comment.
Can we just have if model:here? It is simpler to parse that is not None.
There was a problem hiding this comment.
We can, I replaced it by if model: and did the same in other files.
model/renderer.py
Outdated
|
|
||
| countries = [] | ||
| vendor_extension_extra_pages: List[ExtraPage] = [] | ||
| LEGACY_COUNTRY_CODE = "XX" |
There was a problem hiding this comment.
This is defined, but not used. Why do we need this?
There was a problem hiding this comment.
This is used in other CL (related to this one) that I also sent for review.
There was a problem hiding this comment.
Let's define this where it's used.
norgevz
left a comment
norgevz
left a comment
There was a problem hiding this comment.
LGTM % removing the unused constant.
model/renderer.py
Outdated
|
|
||
| countries = [] | ||
| vendor_extension_extra_pages: List[ExtraPage] = [] | ||
| LEGACY_COUNTRY_CODE = "XX" |
There was a problem hiding this comment.
Let's define this where it's used.
2 participants
Uh oh!
There was an error while loading. Please reload this page.