Fixing the PL street name parsing for street names starting with street prefix#82
Merged
skyman503 merged 4 commits intobattre:mainfrom Dec 19, 2025
Merged
Fixing the PL street name parsing for street names starting with street prefix#82skyman503 merged 4 commits intobattre:mainfrom
skyman503 merged 4 commits intobattre:mainfrom
Conversation
Collaborator
|
LGTM % test case |
norgevz
approved these changes
Dec 18, 2025
Collaborator
norgevz
left a comment
norgevz
left a comment
There was a problem hiding this comment.
LGTM % one small ask.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newly introduced test case reproduces the problem:
In situations when the street name starts with the street prefix (e.g. "Ulubiona"), the "Ul" prefix would be stripped to produce Street with name "lubiona".