restore compatibility with node 0.10* #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I tested this with "npm test" under node 0.10 as well as more recent node. I'm aware that this is a VERY old version of node; we're slowly trying to dig out of this hole, and this is one step towards doing so, and as you can see the changes are minimal. |
added 2 commits
June 4, 2020 12:28
The code currently assumes there are no additional fields to a 'struct flock', but this is not necessarily true, for example on Solaris-derived systems. Signed-off-by: John Levon <john.levon@joyent.com>
Use Nan::To() in the necessary places. Signed-off-by: John Levon <john.levon@joyent.com>
…an" version Reviewed by: Carlos Neira <cneira@edgecast.io> Reviewed by: Travis Paul <tpaul@edgecast.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Nan::To() in the necessary places.
Signed-off-by: John Levon john.levon@joyent.com