Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ buildifier:
build_flags:
- "--keep_going"
- "--build_tag_filters=-integration-test"
- "--announce_rc"
test_targets:
- "--"
- "..."
Expand Down
2 changes: 2 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ build --incompatible_default_to_explicit_init_py
# Ensure ongoing compatibility with this flag.
common --incompatible_disallow_struct_provider_syntax

common --incompatible_strict_action_env

# Windows makes use of runfiles for some rules
build --enable_runfiles

Expand Down
1 change: 1 addition & 0 deletions examples/bzlmod/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ test --test_output=errors --enable_runfiles

# Windows requires these for multi-python support:
build --enable_runfiles
build --incompatible_strict_action_env
common:bazel7.x --incompatible_python_disallow_native_rules
8 changes: 6 additions & 2 deletions tests/integration/custom_commands_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import logging
import unittest

from tests.integration import runner
Expand All @@ -21,7 +20,12 @@
class CustomCommandsTest(runner.TestCase):
# Regression test for https://github.com/bazel-contrib/rules_python/issues/1840
def test_run_build_python_zip_false(self):
result = self.run_bazel("run", "--build_python_zip=false", "//:bin")
result = self.run_bazel(
"run",
"--build_python_zip=false",
"--incompatible_strict_action_env=false",
"//:bin",
)
self.assert_result_matches(result, "bazel-out")


Expand Down