Skip to content

Conversation

@DmitriiTcimbal
Copy link

@DmitriiTcimbal DmitriiTcimbal commented Jun 19, 2024

There might be cases when universal_binary rule has to be used in the absence of a local Xcode/CLT installation. This MR allows the location of the Lipo tool to be provided via the custom toolchain.

@google-cla
Copy link

google-cla bot commented Jun 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@keith
Copy link
Member

keith commented Jul 5, 2025

I don't think it's possible to use this rule without xcode installed since it relies on this?

"_xcode_config": attr.label(

@keith
Copy link
Member

keith commented Jul 17, 2025

I think im wrong about that and it must be a no-op for linux at the very least. at first i wasn't thinking we should merge this but i've since seen that grpc started using this rule, and if you want to avoid major xcode version dependence you need this, so i think we should probably move forward with it. can you rebase and sign the CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants