Move magic compiler wrapper args to env vars #429
+72
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
keith
commented
Sep 3, 2025
crosstool/cc_toolchain_config.bzl
Outdated
| key = "DSYM_HINT_LINKED_BINARY", | ||
| value = "%{output_execpath}", | ||
| # We need to check this for backwards compatibility with bazel 7 | ||
| expand_if_available = "dsym_path", |
Member
Author
There was a problem hiding this comment.
turns out this isn't available on env_entry in bazel 7.x
This lets us avoid trying to parse these values out of various arguments and instead we just get them through the environment.
keith
force-pushed
the
ks/move-magic-compiler-wrapper-args-to-env-vars
branch
from
c88669f to
3e8701b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us avoid trying to parse these values out of various arguments
and instead we just get them through the environment.