Move package() up when safe #1422
Open
+190
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are assignments above package() calls they could contain variables used in the package() call. We now check for that case so we can move it as far up as possible. Fixes bazelbuild#1420
keith
commented
Dec 3, 2025
| usedSymbols := UsedSymbols(pkg.Call) | ||
| for varName := range definedVars { | ||
| if usedSymbols[varName] { | ||
| return false |
Member
Author
There was a problem hiding this comment.
note it is possible to instead of bailing here move to just below the var that is actually used, but that doesn't seem super important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are assignments above package() calls they could contain
variables used in the package() call. We now check for that case so we
can move it as far up as possible.
Fixes #1420