Skip to content

Conversation

@renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
catch2 bazel_dep minor 3.11.03.12.0

Release Notes

catchorg/Catch2 (catch2)

v3.12.0

Fixes
  • Fixed unscoped messages after a passing fast-pathed assertion being lost.
  • Fixed the help string for --order to mention random order as the default. (#​3045)
  • Fixed small documentation typos. (#​3039)
  • Fixed compilation with CATCH_CONFIG_THREAD_SAFE_ASSERTIONS for older C++ standards.
  • Fixed a thread-safety issue with message macros being used too early after the process starts.
  • Fixed automatic configuration to properly handle PlayStation platform. (#​3054)
  • Fixed the weird behaviour of section filtering when specifying multiple filters. (#​3038)
Improvements
  • Added lifetimebound attribute to various places.
    • As an example, compiler that supports lifetime analysis will now diagnose invalid use of Matcher combinators.
  • Minor compile-time improvements to stringification. (#​3028)
    • std::tuple printer does not recurse.
    • Some implementation details were outlined into the cpp file.
  • Global variables will only be marked with thread_local in thread-safe builds. (#​3044)
Miscellaneous
  • The thread safety support is no longer experimental.
    • The new CMake option and C++ define is now CATCH_CONFIG_THREAD_SAFE_ASSERTIONS.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@github-actions github-actions bot added product: CLion CLion plugin awaiting-review Awaiting review from Bazel team on PRs labels Jan 6, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a routine dependency update, upgrading the catch2 C++ testing framework to its v3.12.0 release. This minor version bump incorporates several bug fixes addressing issues like message handling, compilation, and platform support, alongside performance improvements and the stabilization of thread-safety features. The update ensures the project utilizes the latest enhancements and stability offered by the catch2 library.

Highlights

  • Dependency Update: The catch2 testing framework has been updated from version 3.11.0 to 3.12.0 across multiple Bazel module files.
  • Bug Fixes: Version 3.12.0 includes fixes for issues such as unscoped messages, an incorrect help string for --order, documentation typos, compilation with CATCH_CONFIG_THREAD_SAFE_ASSERTIONS for older C++ standards, thread-safety with message macros, PlayStation platform handling, and the 'weird' behavior of section filtering.
  • Improvements: Key improvements include the addition of the lifetimebound attribute to various places for better compiler diagnostics, minor compile-time enhancements to stringification, and marking global variables with thread_local only in thread-safe builds.
  • Thread Safety: The experimental status of thread safety support has been removed, and the new configuration option is CATCH_CONFIG_THREAD_SAFE_ASSERTIONS.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the catch2 dependency to version 3.12.0 in three separate test projects. The changes are consistent across all modified files. I have added one suggestion to improve long-term maintainability by centralizing the dependency version management, which could reduce future maintenance effort and prevent potential inconsistencies. Apart from this suggestion, the PR is good to merge.

@@ -1,3 +1,3 @@
bazel_dep(name = "rules_cc", version = "0.2.16")
bazel_dep(name = "catch2", version = "3.11.0")
bazel_dep(name = "catch2", version = "3.12.0")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version for catch2 is defined in multiple MODULE.bazel files for different test projects (execution, external_includes, and simple). This duplication can make future updates error-prone and increase maintenance effort.

To improve maintainability, consider centralizing the version definition. If these test projects are resolved within the same Bazel workspace during tests, you could add bazel_dep(name = "catch2", version = "3.12.0") to the root MODULE.bazel file. Bazel's Multiple-Version Override (MVO) policy would then ensure this version is used everywhere. This would allow you to manage the version in a single place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review Awaiting review from Bazel team on PRs product: CLion CLion plugin

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants