-
Notifications
You must be signed in to change notification settings - Fork 338
chore(deps): update dependency catch2 to v3.12.0 #8089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a routine dependency update, upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the catch2 dependency to version 3.12.0 in three separate test projects. The changes are consistent across all modified files. I have added one suggestion to improve long-term maintainability by centralizing the dependency version management, which could reduce future maintenance effort and prevent potential inconsistencies. Apart from this suggestion, the PR is good to merge.
| @@ -1,3 +1,3 @@ | |||
| bazel_dep(name = "rules_cc", version = "0.2.16") | |||
| bazel_dep(name = "catch2", version = "3.11.0") | |||
| bazel_dep(name = "catch2", version = "3.12.0") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version for catch2 is defined in multiple MODULE.bazel files for different test projects (execution, external_includes, and simple). This duplication can make future updates error-prone and increase maintenance effort.
To improve maintainability, consider centralizing the version definition. If these test projects are resolved within the same Bazel workspace during tests, you could add bazel_dep(name = "catch2", version = "3.12.0") to the root MODULE.bazel file. Bazel's Multiple-Version Override (MVO) policy would then ensure this version is used everywhere. This would allow you to manage the version in a single place.
This PR contains the following updates:
3.11.0→3.12.0Release Notes
catchorg/Catch2 (catch2)
v3.12.0Fixes
--orderto mention random order as the default. (#3045)CATCH_CONFIG_THREAD_SAFE_ASSERTIONSfor older C++ standards.Improvements
lifetimeboundattribute to various places.std::tupleprinter does not recurse.thread_localin thread-safe builds. (#3044)Miscellaneous
CATCH_CONFIG_THREAD_SAFE_ASSERTIONS.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.