[maintenance] Windows CI #1439
Open
[maintenance] Windows CI #1439
+685
−379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agluszak
force-pushed
the
windows-ci
branch
2 times, most recently
from
f43b6d5 to
fca7208
Compare
This change enables Windows builds and tests in the CI pipeline and fixes various Windows compatibility issues throughout the codebase. Platform-specific path handling: - Replace /dev/null with ctx.actions.declare_file for null outputs on Windows - Use platform-appropriate path separators in classpath construction - Fix bzlmod classpath resolution for Kotlin compiler on Windows Ktlint fixes: - Simplify ktlint_fix and ktlint_test implementations - Use proper argument files instead of shell-specific constructs - Remove windows.bzl utility in favor of inline platform checks Test infrastructure: - Convert integration test runner to java_binary for cross-platform support - Fix temporary file handling in tests for Windows compatibility - Update test assertions to handle platform-specific path formats CI configuration: - Enable Windows builds in presubmit.yml - Add Windows-specific bazelrc configurations - Update MODULE.bazel with Windows toolchain support
Bencodes
reviewed
Jan 6, 2026
| executable_name = executable_name + ".exe" | ||
| return ctx.actions.declare_file(executable_name) | ||
|
|
||
| def _create_windows_exe_launcher(ctx, executable, java_executable, classpath, main_class, jvm_flags_for_launcher, runfiles_enabled, coverage_main_class = None): |
Collaborator
There was a problem hiding this comment.
Is most of this impl. just copied over from the java rules? https://github.com/bazelbuild/rules_java/blob/aa0345c749ae24b4ff3e9ca92e52bbcd96bc135a/java/bazel/rules/bazel_java_binary.bzl#L280-L304
agluszak
requested review from
ahumesky,
cgruber,
nkoroste and
restingbull
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables Windows builds and tests in the CI pipeline and fixes
various Windows compatibility issues throughout the codebase.
Platform-specific path handling:
Ktlint fixes:
Test infrastructure:
CI configuration: