Draft
Conversation
Collaborator
|
Thank you for this! Reviewing now |
nathaniel-brough
requested changes
Nov 2, 2020
Collaborator
nathaniel-brough
left a comment
nathaniel-brough
left a comment
There was a problem hiding this comment.
This is looking good, if you can just fix up the sha256, that would be fantastic. I'm going to add all of the external repository stuff to the CI at some point as well. For now I am just going to do this manually.
I will wait until you have completed an example before merging.
| VERSIONS = { | ||
| "1.8.2" : { | ||
| "commit" : "441b2cbdc25aa50437a59c4bffe22b88e78942c9", | ||
| "sha256" : "" |
Collaborator
There was a problem hiding this comment.
Please add a complete sha256 just to confirm determinism. If you leave this empty it should print out the sha256 when it fetches the remote reposistory.
Author
There was a problem hiding this comment.
Got it. Will finish up the example this weekend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added stm32f1cube bazel files. Planning to add an example as well.