Add ability to toggle showing/hiding channel that a message was sent …#45
Merged
bbbscarter merged 3 commits intobbbscarter:masterfrom Mar 1, 2018
Merged
Add ability to toggle showing/hiding channel that a message was sent …#45bbbscarter merged 3 commits intobbbscarter:masterfrom
bbbscarter merged 3 commits intobbbscarter:masterfrom
Conversation
…to in the log output.
bbbscarter
requested changes
Feb 27, 2018
Owner
bbbscarter
left a comment
bbbscarter
left a comment
There was a problem hiding this comment.
Nice! Very happy to take this with some minor modifications.
| showTimes ? log.GetRelativeTimeStampAsString() : "", | ||
| showChannels || showTimes ? " : " : "", | ||
| showMessage | ||
| ); |
Owner
There was a problem hiding this comment.
I'm finding the conditional operators hard to parse here. Could we refactor into something like:
var channelMessage = showChannels ? String.Format("[{0}] : ", log.Channel : "";
var timeMessage = showTime ? log.GetRelativeTimeStampAsString() + " : " : "";
showMessage = String.Format("{0}{1}{2}". channelMessage, timeMessage, showMessage);
…ity. Add comment explaining expected output for reference.
…n if display channels setting is enabled). Prevents '[]' from showing up for non-channel based logs.
Owner
|
Super - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to in the log output.
(opening new pull request with branched version, as request in #42 )