Use node-fetch instead of request for default transport#40
Merged
jamierbower merged 69 commits intomasterfrom Sep 22, 2023
Merged
Use node-fetch instead of request for default transport#40jamierbower merged 69 commits intomasterfrom
jamierbower merged 69 commits intomasterfrom
Conversation
|
I still get notifications about this 😂 Anyway, looks like a lot of changes, including bumping the minimum version of Node to 18. Any reason you wouldn’t do a 4.0.0 release? This all looks too much to be a patch bump. The public API may not have changed but there may be unexpected dependencies on As you’re forcing v18 of NodeJS you could use the built in fetch API, but I can understand if you’re put off by the “experimental” tag. My understanding is it’s pretty stable to use and reduces your dependencies. Just my 2 pence. |
onlyonehas
approved these changes
Sep 14, 2023
JohnNewman1
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Types of changes
Checklist: