Update and rename PrBoom-Plus_2_5_1_5.sh to PrBoom-Plus_2_5_1_6.sh#3
Open
jrronimo wants to merge 1 commit intobbond007:masterfrom
Open
Update and rename PrBoom-Plus_2_5_1_5.sh to PrBoom-Plus_2_5_1_6.sh#3jrronimo wants to merge 1 commit intobbond007:masterfrom
jrronimo wants to merge 1 commit intobbond007:masterfrom
Conversation
I added a few lines that list all of the .wad files in $DOOM_HOME_DIR and lets the user pick which .wad to load. I'm not sure what the prboom-plus.wad file is, so I'm not sure if it should be included in the list. (I suspect it's the shareware wad of Doom 2?)
jrronimo
commented
Oct 13, 2020
| @@ -16,6 +16,21 @@ DOOM_EXE_NAME="prboom-plus" | |||
| DOOM_OPTIONS="" | |||
Author
There was a problem hiding this comment.
For my modifications to work, "-iwad " needs to be added to the DOOM_OPTIONS="" line. doom.wad (from Doom 1) otherwise tries to load as a pwad and loads incorrectly.
That said, this script only works for IWADs... maybe it's worthwhile to have a separate directory for IWADs and PWADs so that players can load whichever game they prefer with whatever options they prefer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a few lines that list all of the .wad files in $DOOM_HOME_DIR and lets the user pick which .wad to load.
I'm not sure what the prboom-plus.wad file is, so I'm not sure if it should be included in the list. (I suspect it's the shareware wad of Doom 2?)
The last line is showing up because I have a habit of removing trailing extra spaces and empty lines, sorry, haha.